[PATCH] D63901: [WebAssembly] Added visibility and ident directives to WasmAsmParser.

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 27 14:52:04 PDT 2019


aardappel added a comment.

Reviewers: the code parsing these directives is from ELFAsmParser. We decided in the past that WASM should have its own container format parser, since it is a very different format from ELF, but copying code is never fun. Any suggestions here? Inherit from ELFAsmParser or take it as a member (may have unintended consequences). Pull into new base class for both (ELF people may not be happy with that). Or just ignore it?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63901/new/

https://reviews.llvm.org/D63901





More information about the llvm-commits mailing list