[PATCH] D63496: [WIP] CodeGen: Prototype class for registers

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 19 16:43:08 PDT 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: include/llvm/CodeGen/Register.h:23-25
+  static bool isPhysicalRegister(unsigned Reg) {
+    return int(Reg) > 0;
+  }
----------------
bogner wrote:
> Any particular reason to have static methods that take an unsigned instead of just implementing these directly using `this`'s `Reg` in `isVirtual` and friends?
Not really, but this was easier to copy-paste from the existing functions


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63496/new/

https://reviews.llvm.org/D63496





More information about the llvm-commits mailing list