[PATCH] D63496: [WIP] CodeGen: Prototype class for registers

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 19 16:38:06 PDT 2019


bogner added inline comments.


================
Comment at: include/llvm/CodeGen/Register.h:23-25
+  static bool isPhysicalRegister(unsigned Reg) {
+    return int(Reg) > 0;
+  }
----------------
Any particular reason to have static methods that take an unsigned instead of just implementing these directly using `this`'s `Reg` in `isVirtual` and friends?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63496/new/

https://reviews.llvm.org/D63496





More information about the llvm-commits mailing list