[PATCH] D63496: [WIP] CodeGen: Prototype class for registers

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 20 10:53:55 PDT 2019


dsanders added a comment.

Agreed. I like the direction this is going



================
Comment at: include/llvm/CodeGen/Register.h:56
+    return Reg;
+  }
+
----------------
arsenm wrote:
> qcolombet wrote:
> > Ditto.
> I think this is necessary to make this a manageable sized patch. I was hoping to minimize the amount of code touched at once, so this can possibly be removed later
I agree that `operator unsigned()` will need to be removed to complete the migration but I also see the point about limiting the size of the patch. I'm ok with it being removed in a follow-up step. We can get an idea of how big a job removing it is by marking it deprecated and seeing how many warnings that causes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63496/new/

https://reviews.llvm.org/D63496





More information about the llvm-commits mailing list