[PATCH] D63313: [llvm-objcopy] Remove no-op flush of errs

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 04:21:57 PDT 2019


jhenderson added a comment.

In D63313#1543286 <https://reviews.llvm.org/D63313#1543286>, @lebedev.ri wrote:

> What about `llvm::outs()`?


llvm::outs() is buffered, so would need flushing, although I vaguely remember seeing something in the code somewhere that automatically did it on process termination.

To be clear, is there an issue with this specific change, which is dealing with llvm::errs() only?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63313/new/

https://reviews.llvm.org/D63313





More information about the llvm-commits mailing list