[PATCH] D63313: [llvm-objcopy] Remove no-op flush of errs

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D63313#1543284 <https://reviews.llvm.org/D63313#1543284>, @jhenderson wrote:

> In D63313#1543159 <https://reviews.llvm.org/D63313#1543159>, @lebedev.ri wrote:
>
> > In D63313#1543002 <https://reviews.llvm.org/D63313#1543002>, @abrachet wrote:
> >
> > > https://github.com/llvm/llvm-project/blob/master/llvm/lib/Support/raw_ostream.cpp#L854 shows that errs is unbuferred.
> >
> >
> > That's actually kind-of a problem. Unless *something* ensures that all the output
> >  that was written into that is flushed, it may end up being dropped, rL360124 <https://reviews.llvm.org/rL360124>.
>
>
> It depends on the stream being used `errs()` shouldn't need flushing because of its unbuffered state.


What about `llvm::outs()`?

> Other streams (as fixed by rL360124 <https://reviews.llvm.org/rL360124>) will do.




Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63313/new/

https://reviews.llvm.org/D63313