[PATCH] D63313: [llvm-objcopy] Remove no-op flush of errs

Fri Jun 14 04:27:56 PDT 2019

lebedev.ri added a comment.

In D63313#1543330 <https://reviews.llvm.org/D63313#1543330>, @jhenderson wrote:

> In D63313#1543286 <https://reviews.llvm.org/D63313#1543286>, @lebedev.ri wrote:
>
> > What about `llvm::outs()`?
>
>
> llvm::outs() is buffered, so would need flushing,

Ah yes, i see it now, in `llvm::errs()` (in `raw_ostream.cpp`) the stream is created explicitly unbuffered, which is not the case for `llvm::outs()`

> although I vaguely remember seeing something in the code somewhere that automatically did it on process termination.

No, there is no such thing i'm afraid, else i would not have had that bug..

> To be clear, is there an issue with this specific change, which is dealing with llvm::errs() only?

No, looks like all good, sorry about the noise.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63313/new/

https://reviews.llvm.org/D63313