[PATCH] D63075: [TargetLowering] Add MachineMemOperand::Flags to allowsMemoryAccess tests (PR42123)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 06:37:23 PDT 2019


RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: include/llvm/CodeGen/TargetLowering.h:1430
+  bool
+  allowsMemoryAccess(LLVMContext &Context, const DataLayout &DL, EVT VT,
+                     unsigned AddrSpace = 0, unsigned Alignment = 1,
----------------
arsenm wrote:
> Tangentially related, but do we really need to pass the EVT here? I was trying to use this in GlobalISel recently, and this was an issue. The TTI wrapper already doesn't use a specific type
We might be able to get away with "unsigned DataSize", but I'm a little dubious - I'll know later on once I've got all the NT vector handling completed in x86.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63075/new/

https://reviews.llvm.org/D63075





More information about the llvm-commits mailing list