[PATCH] D63075: [TargetLowering] Add MachineMemOperand::Flags to allowsMemoryAccess tests (PR42123)

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 06:32:28 PDT 2019


arsenm added inline comments.


================
Comment at: include/llvm/CodeGen/TargetLowering.h:1430
+  bool
+  allowsMemoryAccess(LLVMContext &Context, const DataLayout &DL, EVT VT,
+                     unsigned AddrSpace = 0, unsigned Alignment = 1,
----------------
Tangentially related, but do we really need to pass the EVT here? I was trying to use this in GlobalISel recently, and this was an issue. The TTI wrapper already doesn't use a specific type


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63075/new/

https://reviews.llvm.org/D63075





More information about the llvm-commits mailing list