[PATCH] D63075: [TargetLowering] Add MachineMemOperand::Flags to allowsMemoryAccess tests (PR42123)

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz added a comment.

LGTM.



================
Comment at: include/llvm/CodeGen/TargetLowering.h:1430
+  bool
+  allowsMemoryAccess(LLVMContext &Context, const DataLayout &DL, EVT VT,
+                     unsigned AddrSpace = 0, unsigned Alignment = 1,
----------------
RKSimon wrote:
> arsenm wrote:
> > Tangentially related, but do we really need to pass the EVT here? I was trying to use this in GlobalISel recently, and this was an issue. The TTI wrapper already doesn't use a specific type
> We might be able to get away with "unsigned DataSize", but I'm a little dubious - I'll know later on once I've got all the NT vector handling completed in x86.
It's the data type that decides how the value is handled.  In that sense it serves as the source of this kind of information, so it should be passed here, even if specific targets only need the size.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63075/new/

https://reviews.llvm.org/D63075