[PATCH] D62598: [AArch64][ELF][llvm-objdump] Add support for PLT decoding with BTI instructions present

[Peter Smith via Phabricator via llvm-commits]

peter.smith marked 2 inline comments as done.
peter.smith added a comment.

Thanks for the comments, will have an update later today.



================
Comment at: test/tools/llvm-objdump/AArch64/plt.test:8
+
+// RUN: llvm-objdump -d -mattr=+bti %p/Inputs/bti-pac-plt.elf-aarch64 | \
+// RUN:   FileCheck --check-prefix=CHECK-BTI %s
----------------
grimar wrote:
> Should we use yaml2obj instead of adding one more precompiled binary?
I'll give it a go. In theory I need to put a PLT section with instructions in so if I can do that with yaml2obj I'll do that.


================
Comment at: test/tools/llvm-objdump/AArch64/plt.test:9
+// RUN: llvm-objdump -d -mattr=+bti %p/Inputs/bti-pac-plt.elf-aarch64 | \
+// RUN:   FileCheck --check-prefix=CHECK-BTI %s
+# CHECK-BTI: bl {{.*}} <f1 at plt>
----------------
grimar wrote:
> Lets do not mix the `//` and `#`.
Thanks for the spot, will fix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62598/new/

https://reviews.llvm.org/D62598