[PATCH] D62598: [AArch64][ELF][llvm-objdump] Add support for PLT decoding with BTI instructions present

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 02:45:44 PDT 2019


grimar added inline comments.


================
Comment at: test/tools/llvm-objdump/AArch64/plt.test:8
+
+// RUN: llvm-objdump -d -mattr=+bti %p/Inputs/bti-pac-plt.elf-aarch64 | \
+// RUN:   FileCheck --check-prefix=CHECK-BTI %s
----------------
peter.smith wrote:
> grimar wrote:
> > Should we use yaml2obj instead of adding one more precompiled binary?
> I'll give it a go. In theory I need to put a PLT section with instructions in so if I can do that with yaml2obj I'll do that.
Yes, you should be able to set any `Content` for section.
Just use obj2yaml on that binary, it should produce a workable yaml (which you might want to reduce though).

e.g. this is yaml produced from `cfi.elf-aarch64` input also used in this test file:

```
  - Name:            .plt
    Type:            SHT_PROGBITS
    Flags:           [ SHF_ALLOC, SHF_EXECINSTR ]
    Address:         0x00000000000002D8
    AddressAlign:    0x0000000000000008
    EntSize:         0x0000000000000010
    Content:         F07BBFA9F00000F011FE47F910E23F9120021FD61F2003D51F2003D51F2003D510010090110240F91002009120021FD6
```



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62598/new/

https://reviews.llvm.org/D62598





More information about the llvm-commits mailing list