[PATCH] D62598: [AArch64][ELF][llvm-objdump] Add support for PLT decoding with BTI instructions present

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 02:19:05 PDT 2019


grimar added inline comments.


================
Comment at: test/tools/llvm-objdump/AArch64/plt.test:8
+
+// RUN: llvm-objdump -d -mattr=+bti %p/Inputs/bti-pac-plt.elf-aarch64 | \
+// RUN:   FileCheck --check-prefix=CHECK-BTI %s
----------------
Should we use yaml2obj instead of adding one more precompiled binary?


================
Comment at: test/tools/llvm-objdump/AArch64/plt.test:9
+// RUN: llvm-objdump -d -mattr=+bti %p/Inputs/bti-pac-plt.elf-aarch64 | \
+// RUN:   FileCheck --check-prefix=CHECK-BTI %s
+# CHECK-BTI: bl {{.*}} <f1 at plt>
----------------
Lets do not mix the `//` and `#`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62598/new/

https://reviews.llvm.org/D62598





More information about the llvm-commits mailing list