[PATCH] D62542: [WebAssembly] Make Emscripten-specific behavior specific to the Emscripten target

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 15:49:35 PDT 2019


sbc100 added inline comments.


================
Comment at: lib/MC/MCWasmStreamer.cpp:125
   case MCSA_NoDeadStrip:
-    Symbol->setExported();
     break;
----------------
It looks like this is the only caller of `setExported` so you can remove `setExported` and `isExported` and probably also remove WASM_SYMBOL_EXPORTED?

In which case why not just rename WASM_SYMBOL_EXPORTED rather than adding another flag?  Or can you imagine the EXPORTED flag getting set in some other way?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62542/new/

https://reviews.llvm.org/D62542





More information about the llvm-commits mailing list