[PATCH] D62542: [WebAssembly] Make Emscripten-specific behavior specific to the Emscripten target
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 28 12:05:27 PDT 2019
sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.
Comment at: include/llvm/BinaryFormat/Wasm.h:316
const unsigned WASM_SYMBOL_EXPLICIT_NAME = 0x40;
+const unsigned WASM_SYMBOL_IMPLICITLY_USED = 0x80;
Why "implicitly"? It seems like it a very explicit attribute :) How about just "WASM_SYMBOL_NO_STRIP" to match MCSA_NoDeadStrip and the mach-o implementation which is `.no_dead_strip` at the asm level.
CHANGES SINCE LAST ACTION
More information about the llvm-commits