[PATCH] D62542: [WebAssembly] Make Emscripten-specific behavior specific to the Emscripten target

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 08:50:09 PDT 2019


dschuff added a comment.

LGTM in general. Maybe IMPLICITLY_EXPORTED would be an even better name?
Anyway, I'm hoping we can make that export behavior nicer soon; I find the attribute(used) -> export behavior a bit odd too. Once we drop fastcomp it will be easier to redefine EMSCRIPTEN_KEEPALIVE and other things.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62542/new/

https://reviews.llvm.org/D62542





More information about the llvm-commits mailing list