[PATCH] D62255: [llvm-objdump][test] Improve testing of some switches #3

[James Henderson via Phabricator via llvm-commits]

jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: test/tools/llvm-objdump/X86/elf-disasm-dynamic-symbols.test:10
+## they meet the necessary criteria.
+# RUN: llvm-objcopy --strip-all %t %t2
+# RUN: llvm-objdump -d %t2 | FileCheck %s --check-prefixes=CHECK,DYN
----------------
jhenderson wrote:
> rupprecht wrote:
> > nit: use llvm-strip in-place (no `%t2`)
> I'd actually refer not to use llvm-strip here, because that then means if the second part of the test fails, you can't inspect the object used in the first part. But I'm not opposed to it if you feel strongly. Happy to update this afterwards.
refer -> prefer


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62255/new/

https://reviews.llvm.org/D62255