[PATCH] D62255: [llvm-objdump] Improve testing of some switches #3

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 01:42:58 PDT 2019


jhenderson marked 2 inline comments as done.
jhenderson added inline comments.


================
Comment at: test/tools/llvm-objdump/X86/disasm-specific-funcs-mangled-name.test:6
+# RUN: llvm-objdump -d --disassemble-functions=_Z3foov %t.o | FileCheck %s
+# RUN: llvm-objdump -d --disassemble-functions=foo() %t.o | FileCheck %s --check-prefix=NOFOO
+# RUN: llvm-objdump -d -C --disassemble-functions=foo() %t.o | FileCheck %s --check-prefix=NOFOO
----------------
rupprecht wrote:
> `--disassemble-functions=foo()` should be single quoted to handle (), e.g.
> 
> ```
> $ echo foo()
> bash: syntax error near unexpected token `('
> ```
I'll check this before committing. I had this vague impression that lit quotes the arguments, but I might be completely wrong.


================
Comment at: test/tools/llvm-objdump/X86/elf-disasm-dynamic-symbols.test:10
+## they meet the necessary criteria.
+# RUN: llvm-objcopy --strip-all %t %t2
+# RUN: llvm-objdump -d %t2 | FileCheck %s --check-prefixes=CHECK,DYN
----------------
rupprecht wrote:
> nit: use llvm-strip in-place (no `%t2`)
I'd actually refer not to use llvm-strip here, because that then means if the second part of the test fails, you can't inspect the object used in the first part. But I'm not opposed to it if you feel strongly. Happy to update this afterwards.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62255/new/

https://reviews.llvm.org/D62255





More information about the llvm-commits mailing list