[PATCH] D62255: [llvm-objdump][test] Improve testing of some switches #3

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.

Few nits. LGTM.



================
Comment at: test/tools/llvm-objdump/X86/disasm-specific-funcs-mangled-name.test:13
+# CHECK-NEXT:  0000000000000000 _Z3foov:
+# CHECK-NEXT:        0: 90                            nop
+
----------------
I would suggest to reduce amount of spaces here and below.
Looks a bit better when compact:
`0: 90 nop`

Up to you though.


================
Comment at: test/tools/llvm-objdump/X86/disasm-specific-funcs.test:1
-// RUN: yaml2obj -o %t.out %p/Inputs/simple-executable-x86_64.yaml
-// RUN: llvm-objdump -d %t.out -disassemble-functions=main | FileCheck %s
+# RUN: yaml2obj -o %t.out %p/Inputs/simple-executable-x86_64.yaml
+# RUN: llvm-objdump -d %t.out --disassemble-functions=main \
----------------
Add a test case description?


================
Comment at: test/tools/llvm-objdump/X86/disasm-specific-funcs.test:15
+# FOO-NEXT:           c: c3                            retq
+# FOO-NEXT:           d: 0f 1f 00                      nopl    (%rax)
+
----------------
Remove excessive spaces between `FOO-NEXT:` and addresses?


================
Comment at: test/tools/llvm-objdump/X86/disasm-specific-funcs.test:40
+
+# NO-DISASM-NOT: Disassembly
+
----------------
--implicit-check-not=Disassembly ?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62255/new/

https://reviews.llvm.org/D62255