[PATCH] D62188: Speed up --start-lib and --end-lib.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 22 01:27:02 PDT 2019


grimar added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:919
 
+// Initialize this->Symbols. this->Symbols is a parallel array as
+// its corresponding ELF symbol table.
----------------
ruiu wrote:
> grimar wrote:
> > Did you use `this->` intentionally in the comments? I think just `Symbols` would look better.
> This is needed because this is a template derived class. You'll get a compile error if you don't write `this->` in this case.
I was talking about `comments` :)

"Initialize this->Symbols. this->Symbols is a parallel array as" -> "Initialize Symbols. Symbols is a parallel array as"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62188/new/

https://reviews.llvm.org/D62188





More information about the llvm-commits mailing list