[PATCH] D62188: Speed up --start-lib and --end-lib.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 22 01:30:19 PDT 2019
ruiu marked an inline comment as done.
ruiu added inline comments.
================
Comment at: lld/ELF/InputFiles.cpp:919
+// Initialize this->Symbols. this->Symbols is a parallel array as
+// its corresponding ELF symbol table.
----------------
grimar wrote:
> ruiu wrote:
> > grimar wrote:
> > > Did you use `this->` intentionally in the comments? I think just `Symbols` would look better.
> > This is needed because this is a template derived class. You'll get a compile error if you don't write `this->` in this case.
> I was talking about `comments` :)
>
> "Initialize this->Symbols. this->Symbols is a parallel array as" -> "Initialize Symbols. Symbols is a parallel array as"?
Ah. This is for consistency with the code that this comment explains. Not a big deal, but I thought that this is better.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62188/new/
https://reviews.llvm.org/D62188
More information about the llvm-commits
mailing list