[PATCH] D62188: Speed up --start-lib and --end-lib.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu marked 2 inline comments as done.
ruiu added a comment.

I should've said that I used clang *with debug info* for testing.



================
Comment at: lld/ELF/InputFiles.cpp:919
 
+// Initialize this->Symbols. this->Symbols is a parallel array as
+// its corresponding ELF symbol table.
----------------
grimar wrote:
> Did you use `this->` intentionally in the comments? I think just `Symbols` would look better.
This is needed because this is a template derived class. You'll get a compile error if you don't write `this->` in this case.


================
Comment at: lld/ELF/InputFiles.cpp:927
+  if (this->Symbols.empty())
+    this->Symbols.resize(ESyms.size());
+
----------------
grimar wrote:
> What is wrong with calling resize without check? It should do nothing I think.
Good point, I'll do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62188/new/

https://reviews.llvm.org/D62188