[PATCH] D61937: [llvm-readelf] - Rework how we parse the .dynamic section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 20 08:11:06 PDT 2019


grimar marked an inline comment as done.
grimar added a comment.

Thanks for the review, James!



================
Comment at: test/tools/llvm-readobj/elf-dynamic-not-in-pt-dynamic.test:1
+## Show that llvm-readobj/llvm-readelf tools can dump the .dynamic
+## section when it is not in a PT_DYNAMIC segment.
----------------
jhenderson wrote:
> Not sure what happened, but this file is currently showing up twice in the diff!
It is just a 2 different tests with a similar names:
(or I do not observe this bug)

A	M		test/tools/llvm-readobj/elf-dynamic-not-in-pt-dynamic.test (47 lines)	
A	M		test/tools/llvm-readobj/elf-not-dynamic-in-pt-dynamic.test (92 lines)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61937/new/

https://reviews.llvm.org/D61937





More information about the llvm-commits mailing list