[PATCH] D61937: [llvm-readelf] - Rework how we parse the .dynamic section.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one minor additional comment.



================
Comment at: test/tools/llvm-readobj/elf-dynamic-not-in-pt-dynamic.test:1
+## Show that llvm-readobj/llvm-readelf tools can dump the .dynamic
+## section when it is not in a PT_DYNAMIC segment.
----------------
Not sure what happened, but this file is currently showing up twice in the diff!


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:1342
+
+  // We do not want to dump dynamic section if we have no PT_DYNAMIC header.
+  if (!DynamicPhdr)
----------------
Maybe worth extending this comment with. "This matches GNU's behavior."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61937/new/

https://reviews.llvm.org/D61937