[PATCH] D61937: [llvm-readelf] - Rework how we parse the .dynamic section.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-dynamic-not-in-pt-dynamic.test:1
+## Show that llvm-readobj/llvm-readelf tools can dump the .dynamic
+## section when it is not in a PT_DYNAMIC segment.
----------------
grimar wrote:
> jhenderson wrote:
> > Not sure what happened, but this file is currently showing up twice in the diff!
> It is just a 2 different tests with a similar names:
> (or I do not observe this bug)
> 
> A	M		test/tools/llvm-readobj/elf-dynamic-not-in-pt-dynamic.test (47 lines)	
> A	M		test/tools/llvm-readobj/elf-not-dynamic-in-pt-dynamic.test (92 lines)
Oh, right, thanks!


================
Comment at: test/tools/llvm-readobj/elf-not-dynamic-in-pt-dynamic.test:1
+## Show that llvm-readobj/llvm-readelf tools can dump the .dynamic section which
+## is not alone in PT_DYNAMIC segment.
----------------
Perhaps worth naming this elf-non-dynamic-in-pt-dynamic.test


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61937/new/

https://reviews.llvm.org/D61937