[PATCH] D61711: [ELF][Driver] Fix precedence of symbol ordering file and CGProfile

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 18:46:51 PDT 2019


ruiu added inline comments.


================
Comment at: lld/ELF/Driver.cpp:968-970
+    if (Args.hasArg(OPT_call_graph_ordering_file))
+      error("--symbol-ordering-file should NOT be used together"
+            " with --call-graph-order-file");
----------------
Check for invalid combination of flags are usually done in `checkOptions()`. Can you write a check for this combination there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61711/new/

https://reviews.llvm.org/D61711





More information about the llvm-commits mailing list