[PATCH] D61711: [ELF][Driver] Fix precedence of symbol ordering file and CGProfile

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/symbol-ordering-file-cgprofile-conflicts.s:2
+// REQUIRES: x86
+// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1
+// RUN: ld.lld -e A %t1 --no-call-graph-profile-sort -o %t2
----------------
Nit: name the object file `%t.o`, the executable `%t`


================
Comment at: lld/test/ELF/symbol-ordering-file-cgprofile-conflicts.s:31
+
+// RUN: rm %t.call_graph || true
+// RUN: echo "A B 5" > %t.call_graph
----------------
`rm -f`. `-f` suppresses the error if the file doesn't exist.


================
Comment at: lld/test/ELF/symbol-ordering-file-cgprofile-conflicts.s:67
+    .cg_profile C, D, 90
+
----------------
Delete the empty line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61711/new/

https://reviews.llvm.org/D61711