[PATCH] D61711: [ELF][Driver] Fix precedence of symbol ordering file and CGProfile

Thu May 9 10:53:58 PDT 2019

tcwang added a comment.

In D61711#1495928 <https://reviews.llvm.org/D61711#1495928>, @ruiu wrote:

> > (1) When both --symbol-ordering-file=<file> and --call-graph-order-file=<file> are present, whichever flag comes later will take precedence.
>
> It looks like this combination is a misuse of the feature. Instead of silently ignore a flag, I think we should report an error that these flags cannot be used together.
>
> > (2) When only --symbol-ordering-file=<file> is present, it takes precedence over implicit call graph (CGProfile) generated by CGProfilePass enabled in new pass manager.
>
> This is fine by me.

Thanks! Fixed the patch with the suggestions.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61711/new/

https://reviews.llvm.org/D61711