[PATCH] D61604: [InstCombine] sink FP negation of operands through select

[Cameron McInally via llvm-commits]

Ok. I'll take a look at the InstCombine stuff. Will keep you posted.

On Tue, May 7, 2019 at 9:16 AM Kevin Neal <Kevin.Neal at sas.com> wrote:

> I still need to finish D55897 (fptrunc and fpext) and then get back to
> wrapping up D43515 (fptosi and fptoui at this point).
>
> I was working on fneg while waiting for reviews. So it'll be a while
> before I can put a lot of time in it. Any idea on how much more needs to be
> done in InstCombine?
>
> If there's not much more to do in InstCombine then I could probably finish
> it before D43515. But if someone beats me to it then that's fine with me.
>
> How should we handle regressions in code quality that are exposed by tests?
>
> -----Original Message-----
> From: Cameron McInally via Phabricator <reviews at reviews.llvm.org>
> Sent: Monday, May 06, 2019 3:37 PM
> To: spatel at rotateright.com; Kevin Neal <Kevin.Neal at sas.com>;
> cameron.mcinally at nyu.edu; Matthew.Arsenault at amd.com;
> andrew.kaylor at intel.com
> Cc: mcrosier at codeaurora.org; wei.ding2 at amd.com; hiraditya at msn.com;
> llvm-commits at lists.llvm.org; jun.l at samsung.com
> Subject: [PATCH] D61604: [InstCombine] sink FP negation of operands
> through select
>
> EXTERNAL
>
> cameron.mcinally added inline comments.
>
>
> ================
> Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:347
> +  }
> +
>    // Only handle binary operators (including two-operand getelementptr)
> with
> ----------------
> spatel wrote:
> > cameron.mcinally wrote:
> > > Do you know what pass needs updating so that we can use the UnOp form?
> I could work on that next...
> > >
> > > If you don't know, that's fine. I can dig it up.
> > I think it's mostly within instcombine - anywhere we're implicitly or
> explicitly (m_BinOp) matching generic binop patterns will not match with
> the new fneg in IR.
> Ok. @kpn already has the bulk of InstCombine covered, so I'll leave that
> to him. If that's okay with you, Kevin.
>
>
> CHANGES SINCE LAST ACTION
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D61604_new_&d=DwIFAg&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=gFDAKtJXUxx5fHRng-AO9zfiFWhoKQ6TM52kBZlUzX4&s=felQr2TqDxLucOnzwUpsxAHwwQAJDf8-uvkUvSBlJ4o&e=
>
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D61604&d=DwIFAg&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=gFDAKtJXUxx5fHRng-AO9zfiFWhoKQ6TM52kBZlUzX4&s=2Svw3FweUKl6VX3Bx1HBGCpJV_a4NiPo8qezygMSxj0&e=
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190507/f7eb5acf/attachment.html>