[PATCH] D61604: [InstCombine] sink FP negation of operands through select

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Tue May 7 08:43:47 PDT 2019


On Tue, May 7, 2019 at 7:16 AM Kevin Neal <Kevin.Neal at sas.com> wrote:

>
> How should we handle regressions in code quality that are exposed by tests?
>

One idea I had (or I may be remembering someone else's suggestion) was to
grep the existing IR regression tests for 'fsub -0.0', then create a
sibling test using fneg. If that doesn't result in the same output, then we
need to do some pattern matching enhancement.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190507/4b6a6e6d/attachment.html>


More information about the llvm-commits mailing list