<div dir="ltr">Ok. I'll take a look at the InstCombine stuff. Will keep you posted.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 7, 2019 at 9:16 AM Kevin Neal <<a href="mailto:Kevin.Neal@sas.com">Kevin.Neal@sas.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">I still need to finish D55897 (fptrunc and fpext) and then get back to wrapping up D43515 (fptosi and fptoui at this point).<br>
<br>
I was working on fneg while waiting for reviews. So it'll be a while before I can put a lot of time in it. Any idea on how much more needs to be done in InstCombine? <br>
<br>
If there's not much more to do in InstCombine then I could probably finish it before D43515. But if someone beats me to it then that's fine with me.<br>
<br>
How should we handle regressions in code quality that are exposed by tests?<br>
<br>
-----Original Message-----<br>
From: Cameron McInally via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> <br>
Sent: Monday, May 06, 2019 3:37 PM<br>
To: <a href="mailto:spatel@rotateright.com" target="_blank">spatel@rotateright.com</a>; Kevin Neal <<a href="mailto:Kevin.Neal@sas.com" target="_blank">Kevin.Neal@sas.com</a>>; <a href="mailto:cameron.mcinally@nyu.edu" target="_blank">cameron.mcinally@nyu.edu</a>; <a href="mailto:Matthew.Arsenault@amd.com" target="_blank">Matthew.Arsenault@amd.com</a>; <a href="mailto:andrew.kaylor@intel.com" target="_blank">andrew.kaylor@intel.com</a><br>
Cc: <a href="mailto:mcrosier@codeaurora.org" target="_blank">mcrosier@codeaurora.org</a>; <a href="mailto:wei.ding2@amd.com" target="_blank">wei.ding2@amd.com</a>; <a href="mailto:hiraditya@msn.com" target="_blank">hiraditya@msn.com</a>; <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>; <a href="mailto:jun.l@samsung.com" target="_blank">jun.l@samsung.com</a><br>
Subject: [PATCH] D61604: [InstCombine] sink FP negation of operands through select<br>
<br>
EXTERNAL<br>
<br>
cameron.mcinally added inline comments.<br>
<br>
<br>
================<br>
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:347<br>
+  }<br>
+<br>
   // Only handle binary operators (including two-operand getelementptr) with<br>
----------------<br>
spatel wrote:<br>
> cameron.mcinally wrote:<br>
> > Do you know what pass needs updating so that we can use the UnOp form? I could work on that next...<br>
> ><br>
> > If you don't know, that's fine. I can dig it up.<br>
> I think it's mostly within instcombine - anywhere we're implicitly or explicitly (m_BinOp) matching generic binop patterns will not match with the new fneg in IR.<br>
Ok. @kpn already has the bulk of InstCombine covered, so I'll leave that to him. If that's okay with you, Kevin.<br>
<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D61604_new_&d=DwIFAg&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=gFDAKtJXUxx5fHRng-AO9zfiFWhoKQ6TM52kBZlUzX4&s=felQr2TqDxLucOnzwUpsxAHwwQAJDf8-uvkUvSBlJ4o&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D61604_new_&d=DwIFAg&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=gFDAKtJXUxx5fHRng-AO9zfiFWhoKQ6TM52kBZlUzX4&s=felQr2TqDxLucOnzwUpsxAHwwQAJDf8-uvkUvSBlJ4o&e=</a><br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D61604&d=DwIFAg&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=gFDAKtJXUxx5fHRng-AO9zfiFWhoKQ6TM52kBZlUzX4&s=2Svw3FweUKl6VX3Bx1HBGCpJV_a4NiPo8qezygMSxj0&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D61604&d=DwIFAg&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=gFDAKtJXUxx5fHRng-AO9zfiFWhoKQ6TM52kBZlUzX4&s=2Svw3FweUKl6VX3Bx1HBGCpJV_a4NiPo8qezygMSxj0&e=</a><br>
<br>
<br>
<br>
</blockquote></div>