[PATCH] D61622: [FastISel][X86] If selectFNeg fails, fall back to SelectionDAG not treating it as an fsub.

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 18:51:59 PDT 2019

Previous message: [PATCH] D61622: [FastISel][X86] If selectFNeg fails, fall back to SelectionDAG not treating it as an fsub.
Next message: [PATCH] D61622: [FastISel][X86] If selectFNeg fails, fall back to SelectionDAG not treating it as an fsub.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

cameron.mcinally added a comment.

I approved it. Yeah, I see the bug now. selectFNeg(...) should have just returned false and not continued on to selectBinaryOp(...). That was a dumb mistake.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61622/new/

https://reviews.llvm.org/D61622

Previous message: [PATCH] D61622: [FastISel][X86] If selectFNeg fails, fall back to SelectionDAG not treating it as an fsub.
Next message: [PATCH] D61622: [FastISel][X86] If selectFNeg fails, fall back to SelectionDAG not treating it as an fsub.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list