[PATCH] D61622: [FastISel][X86] If selectFNeg fails, fall back to SelectionDAG not treating it as an fsub.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 18:19:23 PDT 2019


craig.topper added a comment.

In D61622#1492800 <https://reviews.llvm.org/D61622#1492800>, @craig.topper wrote:

> In D61622#1492790 <https://reviews.llvm.org/D61622#1492790>, @cameron.mcinally wrote:
>
> > Ah, I see it now. Thanks for the explanation.
> >
> > I'd like to review this, but the FastISel code under the hood is outside of my domain. If no one else chimes in, I'll dig into it tomorrow.
>
>
> If nothing else, I think you can at least confirm this returns things back to the behavior that would have existed prior to r345295


And by behavior I mean from a control flow perspective in this file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61622/new/

https://reviews.llvm.org/D61622





More information about the llvm-commits mailing list