[PATCH] D61337: [hwasan] Fix HWASAN_WITH_INTERCEPTORS=OFF build on not-android.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 17:24:45 PDT 2019


eugenis added a comment.

>>> Should this be an error and cause an "unsupported configuration"?
>> 
>> But we don't really know that, because a change that makes this configuration supported needs to be in libc or in platform build files, not in compiler-rt. I'd rather not block anyone from experimenting.
> 
> What about makeing it a warning, "untested configuration"? Obviously your call, just seems prudent to me.

Sorry, but I don't like it for the same reason.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61337/new/

https://reviews.llvm.org/D61337





More information about the llvm-commits mailing list