[PATCH] D61337: [hwasan] Fix HWASAN_WITH_INTERCEPTORS=OFF build on not-android.

Thu May 2 17:20:13 PDT 2019

winksaville added a comment.

In D61337#1488735 <https://reviews.llvm.org/D61337#1488735>, @eugenis wrote:

> In D61337#1487120 <https://reviews.llvm.org/D61337#1487120>, @winksaville wrote:
>
> > >> @eugenis, which of the following conditions have tests?
> > >> 
> > >> HWASAN_WITH_INTERCEPTORS=OFF, SANITIZER_ANDROID=OFF
> > > 
> > > This configuration does not exist.
> >
> > Should this be an error and cause an "unsupported configuration"?
>
>
> But we don't really know that, because a change that makes this configuration supported needs to be in libc or in platform build files, not in compiler-rt. I'd rather not block anyone from experimenting.

What about makeing it a warning, "untested configuration"? Obviously your call, just seems prudent to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61337/new/

https://reviews.llvm.org/D61337