[PATCH] D61337: [hwasan] Fix HWASAN_WITH_INTERCEPTORS=OFF build on not-android.

Thu May 2 17:44:21 PDT 2019

winksaville added a comment.

In D61337#1488898 <https://reviews.llvm.org/D61337#1488898>, @eugenis wrote:

> >>> Should this be an error and cause an "unsupported configuration"?
> >> 
> >> But we don't really know that, because a change that makes this configuration supported needs to be in libc or in platform build files, not in compiler-rt. I'd rather not block anyone from experimenting.
> > 
> > What about makeing it a warning, "untested configuration"? Obviously your call, just seems prudent to me.
>
> Sorry, but I don't like it for the same reason.

How about a comment something like:

  // Confiturations of HWASAN_WITH_INTERCEPTORS and SANITIZER_ANDROID
  //
  // HWASAN_WITH_INTERCEPTORS=OFF, SANITIZER_ANDROID=OFF
  //
  //   Not currently tested
  //
  // HWASAN_WITH_INTERCEPTORS=OFF, SANITIZER_ANDROID=ON
  //
  //   Integration tests downstream exit
  //
  // HWASAN_WITH_INTERCEPTORS=ON, SANITIZER_ANDROID=OFF
  //
  //    Tested with check-hwasan on x86_64-linux.
  //
  // HWASAN_WITH_INTERCEPTORS=ON, SANITIZER_ANDROID=ON
  //
  //    Tested with check-hwasan on aarch64-linux-android.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61337/new/

https://reviews.llvm.org/D61337