[PATCH] D60616: Make parseBitcodeFile use a named StructType, if it exists and matches.

Arnt Gulbrandsen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 04:41:08 PDT 2019


arnt added a comment.

This patch overlooks a case and should not be merged for now.

Specifically, forward references in the bitcode file cause BitcodeReader::createIdentifiedStructType(LLVMContext &) to create a type, even though the intended type might already exist in the LLVMContext. I'm not sure how to create a test that exercises this clearly and cleanly, or whether this can really be solved. Will have a coffee and a think.

JFYI, my eventual purpose is to do things like reading a class's superclass's Module into the same LLVMContext as the class's own Module.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60616/new/

https://reviews.llvm.org/D60616





More information about the llvm-commits mailing list