[PATCH] D59633: [PowerPC] Look through copies for compare elimination

Thu May 2 04:45:12 PDT 2019

nemanjai marked 4 inline comments as done.
nemanjai added inline comments.

================
Comment at: test/CodeGen/PowerPC/eliminate-compare-of-copy.ll:7
+; CHECK: or. {{r[0-9]+}}, r4, r3
+; CHECK-NOT: cmplwi
+entry:
----------------
stefanp wrote:
> I usually add a `CHECK: blr` at the end so that I know where the end of the function is. In a way it is just like adding the CHECK-LABEL at the start.
> 
Will add on the commit. Thanks.

================
Comment at: test/CodeGen/PowerPC/eliminate-compare-of-copy.ll:14
+if.then:                                          ; preds = %entry
+  %call = tail call signext i32 bitcast (i32 (...)* @f1 to i32 ()*)() #2
+  br label %return
----------------
stefanp wrote:
> nit:
> Cleanup: I don't think that you need the `#0`, `#1` or `#2`. 
Fair enough, I'll remove them.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59633/new/

https://reviews.llvm.org/D59633