[PATCH] D60402: [PowerPC] Collapse RLDICL/RLDICR into RLDIC when possible

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp accepted this revision.
stefanp added a comment.
This revision is now accepted and ready to land.

LGTM.
The one very minor comment I have I think can be addressed on commit.



================
Comment at: test/CodeGen/PowerPC/collapse-rotates.mir:53
+constants:       []
+machineFunctionInfo: {}
+body:             |
----------------
nemanjai wrote:
> stefanp wrote:
> > Had to delete this line on the machine I was running on to get this test to pass...
> > The error is:
> > ```
> > error: YAML:53:23: unknown key 'machineFunctionInfo'
> > machineFunctionInfo: {}
> > ```
> > I'm not sure what the issue is here but I feel like that line is not universally supported.
> I am not sure what that's about. Perhaps you were on an older revision where that wasn't part of MIR?
I have tried to reproduce this since but I have not been able to. I would say don't worry about this.
I assume the issue was on my end.



================
Comment at: test/CodeGen/PowerPC/jump-tables-collapse-rotate.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=powerpc64le-unknown-linux-gnu -o - %s | FileCheck %s
+
----------------
nit:
This is something that I find helps with readability of the test case.
Is it possible to add: `-ppc-asm-full-reg-names`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60402/new/

https://reviews.llvm.org/D60402