[PATCH] D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.



> To clarify, this is failing when building runtimes for Darwin so shouldn't be Fuchsia specific, but it could be affected by some of the Clang defaults we set in our CMake build. We use lld as the default linker for Fuchsia but not for Darwin where use the system linker.

Based on the log the https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8915104112618242800/+/steps/clang/0/steps/build/0/stdout log that @juliehockett pointed to the CMake output suggests that LLD is being used when building the compiler-rt runtime

  [3397/3401] Performing configure step for 'runtimes'
  -- The C compiler identification is Clang 9.0.0
  -- The CXX compiler identification is Clang 9.0.0
  -- The ASM compiler identification is Clang
  -- Found assembler: /b/s/w/ir/k/recipe_cleanup/clangp5sgXt/llvm_build_dir/./bin/clang
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  LLD 9.0.0 (https://fuchsia.googlesource.com/a/third_party/llvm-project 41327e352285df0f437affc5d6b1522ad650f750) (compatible with GNU linkers)
  -- Linker detection: unknown
  ...
  LLD 9.0.0 (https://fuchsia.googlesource.com/a/third_party/llvm-project 41327e352285df0f437affc5d6b1522ad650f750) (compatible with GNU linkers)
  CMake Warning at /b/s/w/ir/k/llvm-project/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:57 (message):
    Detecting supported architectures from 'ld -v' failed.  Returning default
    set.
  Call Stack (most recent call first):
    /b/s/w/ir/k/llvm-project/compiler-rt/cmake/config-ix.cmake:374 (darwin_get_toolchain_supported_archs)
    /b/s/w/ir/k/llvm-project/compiler-rt/CMakeLists.txt:280 (include)

This isn't actually the source of the problem though so I'll ignore this for now.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58578/new/

https://reviews.llvm.org/D58578