[PATCH] D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms.

Fri Apr 26 11:08:27 PDT 2019

phosek added a comment.

In D58578#1480757 <https://reviews.llvm.org/D58578#1480757>, @delcypher wrote:

> @juliehockett
>
> > Sorry about this. I'll revert the patch now and I'll take a look at re-landing it when time permits.
>
> Reverted in r359327. Do you have a script (or something better?) that would let me easily replicate your set up. I suspect your use of LLD + Clang is probably what is different from my set up and leads to the CMake failure. You're building compiler-rt with open source Clang rather than AppleClang (i.e. from Xcode or Xcode command line tools) right?

To clarify, this is failing when building runtimes for Darwin so shouldn't be Fuchsia specific, but it could be affected by some of the Clang defaults we set in our CMake build. We use lld as the default linker for Fuchsia but not for Darwin where use the system linker.

You can see the CMake invocation at top of this page: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8915104112618242800/+/steps/clang/0/steps/configure/0/stdout. It's also worth noting that this was only failing in case of the 2-stage build, the single stage build remained green. I can try to reproduce this locally on my Mac as well if that's helpful.

Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58578/new/

https://reviews.llvm.org/D58578