[PATCH] D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms.

Sat Apr 27 04:16:58 PDT 2019

delcypher added a comment.

> Sure -- to clarify, it's not a test failure, it's a build one. The error was triggered during the CMake configuration step for host runtimes, where we have `OSX supported arches: x86_64` only. `test/tsan/CMakeLists.txt:78` now calls into the new function on the arm64 case, which down the line triggers a CMake assert that arm64 is in the list of supported arches when it isn't.
> 
> Seems like prior to this change, the lit tests were being configured without doing any checks on that list of supported arches. I'm not as familiar with how this code is set up, so I can't really say if it's a problem with this patch or if this patch is exposing another bug. Thanks for taking a look!

Yep it's this patch exposing another bug. Your configuration only seems to allow x86_64 as an architecture (any idea why?) and the CMake code in `test/tsan/CMakeLists.txt` just assumes that arm64 is supported. I'll just hack my build so it's as if `x86_64` was the only supported architecture to replicate this failure, then I'll fix the bug and submit a new patch for review.

Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58578/new/

https://reviews.llvm.org/D58578