[PATCH] D60955: [llvm] Remove final and add default virtual dtor to CommandLine parsers

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 22 13:21:44 PDT 2019


craig.topper added a comment.

This seems to reversing r231221 which devirtualized this.  What kind of customization are you envisioning? There aren't many methods here. Are you planning to override the parse method but still fall back to the base class version sometimes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60955/new/

https://reviews.llvm.org/D60955





More information about the llvm-commits mailing list