[PATCH] D60955: [llvm] Remove final and add default virtual dtor to CommandLine parsers

Mon Apr 22 16:03:56 PDT 2019

dblaikie added a comment.

In D60955#1474642 <https://reviews.llvm.org/D60955#1474642>, @craig.topper wrote:

> This seems to reversing r231221 which devirtualized this.  What kind of customization are you envisioning? There aren't many methods here. Are you planning to override the parse method but still fall back to the base class version sometimes?

Sorry, yeah, there's some missing context in this review description - it was discussed on llvm-dev here: http://lists.llvm.org/pipermail/llvm-dev/2019-April/131873.html

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60955/new/

https://reviews.llvm.org/D60955