[PATCH] D60955: [llvm] Remove final and add default virtual dtor to CommandLine parsers

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/include/llvm/Support/CommandLine.h:901-902
   void anchor() override;
+
+  virtual ~parser() = default;
 };
----------------
Might as well make the dtor public and virtual in the basic_parser class & remove all these explicitly virtual dtor definitions in the derived classes, I guess?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60955/new/

https://reviews.llvm.org/D60955