[PATCH] D60825: [llvm-objcopy] - Check dynamic relocation sections for broken references.

Wed Apr 17 08:45:49 PDT 2019

grimar added a comment.

In D60825#1470322 <https://reviews.llvm.org/D60825#1470322>, @jakehehrlich wrote:

> So overall this looks good and literally yesterday I'd have just given a +2 but James noticed an edge case we should think about. If there are ever reasons to have a dynamic relocation without a symbol table (I don't know of any) we should hold off and account for the edge case. O think that concern only applies to relocatable files however.

In theory, I think R_X86_64_RELATIVE relocations should not need a symbol table since they just adjust a place by program base.
This will be easy to support after landing the D60324 <https://reviews.llvm.org/D60324> which introduce the `--allow-broken-links` option.
We can just wait for it and I'll update this patch then or I could do that in a follow-up.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60825/new/

https://reviews.llvm.org/D60825