[PATCH] D60825: [llvm-objcopy] - Check dynamic relocation sections for broken references.

Thu Apr 18 02:15:55 PDT 2019

jhenderson added a comment.

FYI, I've just landed D60324 <https://reviews.llvm.org/D60324>, and approved D60820 <https://reviews.llvm.org/D60820>. This looks good, except for the edge case mentioned by @jakehehrlich. The code should also implement --allow-broken-links now that that has landed.

================
Comment at: test/tools/llvm-objcopy/ELF/dynrelocsec-remove-shinfo-reference.test:11
+# RUN: llvm-readelf --sections %t2 | \
+# RUN:   FileCheck %s --implicit-check-not=".got.plt" --implicit-check-not=".rela.plt"
+
----------------
I'm not too bothered, but I find it marginally easier to read the line as a continuation if the '|' is on the second line.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60825/new/

https://reviews.llvm.org/D60825