[PATCH] D60825: [llvm-objcopy] - Check dynamic relocation sections for broken references.

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 08:18:25 PDT 2019


jakehehrlich added a comment.

So overall this looks good and literally yesterday I'd have just given a +2 but James noticed an edge case we should think about. If there are ever reasons to have a dynamic relocation without a symbol table (I don't know of any) we should hold off and account for the edge case. O think that concern only applies to relocatable files however.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60825/new/

https://reviews.llvm.org/D60825





More information about the llvm-commits mailing list