[PATCH] D60459: SILoadStoreOptimizer pass mischedules s_add,s_addc with interfering s_lshl

[Ron Lieberman via Phabricator via llvm-commits]

ronlieb marked an inline comment as done.
ronlieb added inline comments.


================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:302
+        else
+          return false;
+      }
----------------
rampitec wrote:
> Does that really mean to bail? Check the uses.
> You also need a test where you did not find the pair, a mir test.
i see what you mean about the bail and uses , thx.
good suggestion for the mir test. will add


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60459/new/

https://reviews.llvm.org/D60459