[PATCH] D60459: SILoadStoreOptimizer pass mischedules s_add,s_addc with interfering s_lshl

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 17:12:38 PDT 2019


rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:302
+        else
+          return false;
+      }
----------------
Does that really mean to bail? Check the uses.
You also need a test where you did not find the pair, a mir test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60459/new/

https://reviews.llvm.org/D60459





More information about the llvm-commits mailing list